-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for EIP-1559 #1835
Comments
@kclowes Thank you very much for starting looking at this. |
No plan on removing legacy transactions in the foreseeable future! |
What was wrong?
It looks like EIP-1559 is coming up soon (maybe in the London hard fork), so we'll need to update web3py to support it. This is a placeholder issue that will likely get broken down into a few issues.
How can it be fixed?
From a high level, it looks like we need to change our transaction object:
Remove gas_price (will probably need to keep it in in v5 and then need to make a note to remove in v6)BlockData will need to change as well:
move gas_limit to gas_target (In v5, we'll need to keep both gas_limit and gas_target and remove gas_limit in v6).Also probably simplifies (possibly removes the need for) our gas price strategies.
@abdelhamidbakhta or @pipermerriam let me know if I'm missing anything!
The text was updated successfully, but these errors were encountered: