Add requests-mock dependency to dev requirements #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, since these tests are not included in CI and are only intended as local smoke tests, perhaps the more appropriate route is to comment out the import or remove the mock template code altogether. No strong feels, but I think I favor the latter. |
kclowes
force-pushed
the
add-requests-mock-lib
branch
3 times, most recently
from
0fd9552 to
af0c019
Compare
wolovim
approved these changes
Jan 13, 2021
tests/beacon/test_beacon.py
Outdated
| text=json.dumps(GENESIS_RESPONSE), | ||
| ) | ||
| return session | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def beacon(session): | ||
| # return Beacon( | ||
| # beacon_url="mock://example.com/api", | ||
| # session=session, | ||
| # ) |
There was a problem hiding this comment.
thanks for cleaning up. this comment and the session arg in this func definition can get removed too 👍
kclowes
force-pushed
the
add-requests-mock-lib
branch
from
af0c019 to
5d1e60a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
requests-mockis used in the beacon tests and I found I couldn't run my tests locally from the top-leveltests/dir without it installed.How was it fixed?
Added requests-mock dependency to setup.py.
@marcgarreau let me know if this is the wrong solution!
Todo:
Cute Animal Picture