Add handler for Ganache revert message format #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
reviewed
Nov 19, 2020
There was a problem hiding this comment.
Thanks for the contribution @Dmitry-Tk! I just left one comment on standardizing the error message with the geth response.
|
@kclowes could you please take a look at this failing |
|
I was able to rerun it for you @Dmitry-Tk. Seems to be working now! |
|
@tmckenzie51 @kclowes could this PR be merged now or some other modifications needed? |
kclowes
reviewed
Nov 30, 2020
kclowes
reviewed
Nov 30, 2020
There was a problem hiding this comment.
@marcgarreau I'm going to leave this for your final approval!
wolovim
force-pushed
the
fix-ganache-revert-reason-parsing
branch
from
99c65cf to
3bfd53d
Compare
wolovim
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1793
How was it fixed?
The case when
datafield in the RPC response isdictwas handled, so Ganache revert reasons could be parsed correctly.Todo:
Cute Animal Picture