Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth to method 5 #1746

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Eth to method 5 #1746

merged 4 commits into from
Sep 18, 2020

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 17, 2020

What was wrong?

The latest in moving eth methods to use Method. This installation includes:

  • eth_getTransactionByBlock
  • eth_getTransactionReceipt
  • eth_sendTransaction

Related to Issue #1585

Todo:

Cute Animal Picture

image

@kclowes kclowes force-pushed the eth-to-method-5 branch 2 times, most recently from df2f720 to dce9031 Compare September 17, 2020 21:56
@kclowes kclowes changed the title [WIP] Eth to method 5 Eth to method 5 Sep 18, 2020
@@ -156,6 +156,8 @@ def validate_address(value: Any) -> None:
"""
Helper function for validating an address
"""
# if value == b'':
# return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if unneeded, 🪓

@kclowes kclowes merged commit 4b4740c into ethereum:master Sep 18, 2020
@kclowes kclowes deleted the eth-to-method-5 branch September 18, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants