Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbundle release notes generation from release command #1687

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Jul 15, 2020

What was wrong?

The make release command compiles and publishes release notes as part of the process. Being able to manually update the auto-generated notes before releasing is useful in the case of moving from beta to stable, for example.

How was it fixed?

Borrows the scripts from Trinity's Makefile.

Todo:

Cute Animal Picture

@wolovim wolovim requested a review from carver July 15, 2020 18:12
Copy link
Collaborator

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think the only release instructions for web3 are in the readme.md. It looks like that needs to be updated.

@wolovim
Copy link
Member Author

wolovim commented Jul 15, 2020

👍 on the todo list is bringing contribution/maintenance docs into RTD, like Trinity. But, for now, README tweak incoming.

@wolovim wolovim merged commit 695f6c3 into ethereum:master Jul 15, 2020
@wolovim wolovim deleted the unbundle-notes-from-release branch July 15, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants