Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct type of FilterParams.address #1664

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Correct type of FilterParams.address #1664

merged 2 commits into from
Jun 2, 2020

Conversation

palango
Copy link
Contributor

@palango palango commented Jun 2, 2020

What was wrong?

The type annotations of FilterParams.address were not complete.

How was it fixed?

Added the missing type.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

wolovim
wolovim approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the correction!

@wolovim wolovim merged commit 225f27e into ethereum:master Jun 2, 2020
@palango palango deleted the correct-filter_params branch June 2, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolovim wolovim wolovim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palango @wolovim