Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block_identifier to Contract.estimateGas #1588

Closed
karlb opened this issue Feb 25, 2020 · 0 comments
Closed

Add block_identifier to Contract.estimateGas #1588

karlb opened this issue Feb 25, 2020 · 0 comments
Labels
Good First Issue

Comments

@karlb
Copy link
Contributor

karlb commented Feb 25, 2020

What was wrong?

Eth.estimateGas takes a block_identifier parameter, but Contract.estimateGas doesn't.

How can it be fixed?

It should be possible to just add the parameter and pass it through to Eth.estimateGas without any other changes.

This issue is analogous to #446.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlb @kclowes