Format 'from' and 'to' fields to checksum addresses in RECEIPT_FORMAT… #1562
Conversation
There was a problem hiding this comment.
Thanks @rajeev29five! Do you mind adding an assertion to the integration tests? Maybe something like assert is_checksum_address(receipt['to']) in the test_eth_getTransactionReceipt_mined test in web3/_utils/module_testing/eth_module.py. Let me know if that's unclear or you need more direction!
|
Ok @kclowes I'll do that. If I'm stuck I'll ask for help. |
|
That would be ideal, but you may need to also add a check to make sure it's there since we're doing the |
|
@kclowes looks like from and to key do not come back with transaction receipt. Little guidance please. |
|
@rajeev29five let's add the xfail decorator ( @pytest.mark.xfail(raises=KeyError, reason="ethereum tester doesn't return 'to' key")
def test_eth_getTransactionReceipt_unmined(self, eth_tester, web3, unlocked_account):
super().test_eth_getTransactionReceipt_unmined(web3, unlocked_account) |
|
@kclowes Need some help with these Failures |
| @@ -298,6 +298,9 @@ def test_eth_chainId(self, web3): | |||
| assert is_integer(chain_id) | |||
| assert chain_id == 61 | |||
|
|
|||
| @pytest.mark.xfail(raises=KeyError, reason="ethereum tester doesn't return 'to' key") | |||
| def test_eth_getTransactionReceipt_unmined(self, eth_tester, web3, unlocked_account): | |||
There was a problem hiding this comment.
I believe this should be def test_eth_getTransactionReceipt_mined. Sorry I mistyped earlier.
| @@ -758,6 +758,7 @@ def test_eth_getTransactionByBlockNumberAndIndex( | |||
| assert is_dict(transaction) | |||
| assert transaction['hash'] == HexBytes(mined_txn_hash) | |||
|
|
|||
| @pytest.mark.xfail(raises=KeyError) | |||
There was a problem hiding this comment.
This is the higest level that gets run for each different client (ethtester, geth, parity). Since only ethtester was failing, you'll need to remove this here. It will be overridden for ethtester where you have it above in tests/integration/test_ethereum_tester.py. Since we don't expect a failure for geth or parity (I don't think), you can remove the xfail here.
| @@ -298,6 +298,9 @@ def test_eth_chainId(self, web3): | |||
| assert is_integer(chain_id) | |||
| assert chain_id == 61 | |||
|
|
|||
| @pytest.mark.xfail(raises=KeyError, reason="ethereum tester doesn't return 'to' key") | |||
| def test_eth_getTransactionReceipt_mined(self, eth_tester, web3, unlocked_account): | |||
| super().test_eth_getTransactionReceipt_unmined(web3, unlocked_account) | |||
There was a problem hiding this comment.
@rajeev29five this line should also be test_eth_getTransactionReceipt_mined. I think then you'll be in good shape as soon as you fix the lint tests.
There was a problem hiding this comment.
@kclowes I was about to ask you about that line but anyways I will make the changes and test for any other failures. Thanks!
There was a problem hiding this comment.
@kclowes What should I pass for positional argument: 'mined_txn_hash' ?
There was a problem hiding this comment.
You'll need to pass in web3, block_with_txn, and mined_txn_hash, just like in the original definition in module_testing/eth_module.py. So the function should look like:
@pytest.mark.fail(...)
def test_eth_getTransactionReceipt_mined(self, web3, block_with_txn, and mined_txn_hash):
super().test_eth_getTransactionReceipt_mined(web3, block_with_txn, and mined_txn_hash)
Sorry for all the confusion. Let me know if you want a better explanation of why.
|
All checks passed. Thanks for all the help : ) @kclowes |
…TERS Add newsfragment for checksum address in txn receipt
What was wrong?
Receipt formatter was not formatting from and to addresses to checksum as it does with transaction formatter.
Related to Issue #1547
How was it fixed?
Followed @ignition42's instructions.
Added from and to here: https://github.com/ethereum/web3.py/blob/v5.4.0/web3/_utils/method_formatters.py#L174
As they were here: https://github.com/ethereum/web3.py/blob/v5.4.0/web3/_utils/method_formatters.py#L119
Cute Animal Picture