Upgrade integration tests to run against geth 1.9 #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
changed the title
kclowes
force-pushed
the
upgrade-geth-190
branch
3 times, most recently
from
d1ae142 to
1e7156a
Compare
kclowes
force-pushed
the
upgrade-geth-190
branch
5 times, most recently
from
b9a3701 to
c431552
Compare
- Conditionally add geth flags based on version - Update py-geth to use higher than 2.2
kclowes
force-pushed
the
upgrade-geth-190
branch
from
79c67ce to
d330c5c
Compare
kclowes
changed the title
pipermerriam
approved these changes
Jan 15, 2020
kclowes
force-pushed
the
upgrade-geth-190
branch
from
163ca10 to
2c90120
Compare
kclowes
force-pushed
the
upgrade-geth-190
branch
from
9a64ec7 to
97bdfff
Compare
kclowes
commented
Jan 16, 2020
| '--nodiscover', | ||
| '--fakepow', | ||
| yield from base_geth_command_arguments | ||
| yield from ( |
There was a problem hiding this comment.
@pipermerriam is there a better way to clean this up instead of using 2 yield froms in a row?
There was a problem hiding this comment.
No, but the two yield from statemeents are what I would do.
kclowes
force-pushed
the
upgrade-geth-190
branch
from
97bdfff to
6c108bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Integration tests didn't cover the new-ish Geth 1.9 releases.
How was it fixed?
Added a fixture for Geth 1.9 and updated tests accordingly.
Todo:
Cute Animal Picture