Fix LogsBloom formatter error #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That parity test is flaky, not something you did. Do you mind adding a test for this functionality? Thanks! |
kclowes
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Looking into this, I don't think it's testable with the versions of geth and parity that we use for our integration testing. It looks like this problem was fixed in geth 1.5 (see here), and parity doesn't have a pending option as of 1.1.11 (see here). That being said, this looks good to me! Thanks @enjeyw!
…n logsBloom is null
kclowes
force-pushed
the
fix_logsbloom_format_error
branch
from
08e1229 to
4fb9319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When
getBlock(block_identifier='pending')is called, the pending block will returnlogsBloom = null. The current block formatter attempts to convert the null value to HexBytes and fail.How was it fixed?
The LogsBloom HexBytes formatter is only applied when logsBloom is not null.
Todo:
Cute Animal Picture