Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web3._utils.formatters in favor of eth-utils versions #1197

Closed
pipermerriam opened this issue Jan 9, 2019 · 2 comments
Closed

Remove web3._utils.formatters in favor of eth-utils versions #1197

pipermerriam opened this issue Jan 9, 2019 · 2 comments

Comments

@pipermerriam
Copy link
Member

Depends on #1195 which upgrades the eth-utils dependency

What was wrong?

https://github.com/ethereum/web3.py/blob/864bc1d2a93ba7a6ca2a0629839b0d7a4c944e12/web3/_utils/formatters.py

We currently have a module web3._utils.formatters which implements a number of functional formatter functions. These functions were elevated to live in eth-utils recently and thus are duplicate code.

How can it be fixed?

Remove any/all functions from web3._utils.formatters in favor of the eth-utils versions.

@dylanjw
Copy link
Contributor

dylanjw commented Jan 16, 2019

Can I include this change in #1209? It might be the same amount of work to do as it would to rebase this change from master.

@pipermerriam
Copy link
Member Author

If they can be done separately that would be ideal since this change should just be code removal and modification of imports. Mixing that with functionality changes makes for more difficult review. Feel free to write them together but to segregate your commits so that when you're done you can split them into two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants