Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1094 to v4 branch #1096

Closed
pipermerriam opened this issue Oct 9, 2018 · 2 comments
Closed

Backport 1094 to v4 branch #1096

pipermerriam opened this issue Oct 9, 2018 · 2 comments
Labels
Good First Issue

Comments

@pipermerriam
Copy link
Member

What was wrong?

#1094 (comment) needs to be backported to the v4 branch.
@pipermerriam pipermerriam mentioned this issue Oct 9, 2018
Closed
@carver
Copy link
Collaborator

carver commented Oct 9, 2018

Also, because of #1012 (comment) maybe we should require >=3.5.3

This was referenced Oct 16, 2018
Merged
Merged
@carver
Copy link
Collaborator

carver commented Oct 16, 2018

Thanks @stefanmendoza !

@carver carver closed this as completed Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carver @pipermerriam