Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Request peer status often and trigger sync after status #1401

Closed
ChihChengLiang opened this issue Dec 17, 2019 · 1 comment
Closed

Request peer status often and trigger sync after status #1401

ChihChengLiang opened this issue Dec 17, 2019 · 1 comment

Comments

@ChihChengLiang
Copy link
Contributor

What is wrong?

Per #1399 (comment)

First, Trinity only requests a peer's STATUS once happened at the handshake, so the peer pool never updates the information of the peer's head slot, finalized root, finalized epoch, etc.

Second, the spec says we should start the sync once we learn the STATUS, while it's not the case in the current implementation.

How can it be fixed

  • We should request the peer's status once for a while to have the updated knowledge of the peer's finalized root and epoch.
  • We should have a way to trigger sync immediately after the handshake.
@ralexstokes
Copy link
Member

Closing due to staleness (and this has also been re-filed here: ethereum/trinity-eth2#17)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants