Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis run in this repository should run cpp-ethereum on the test cases #436

Closed
pirapira opened this issue Mar 22, 2018 · 11 comments
Closed
Labels

Comments

@pirapira
Copy link
Member

Currently, people sometimes file PRs to cpp-ethereum or testeth repository, just to see we are not breaking tests. This is not the correct workflow. Travis run in this repository should take care of that.

@winsvega
Copy link
Collaborator

winsvega commented May 9, 2018

A PR here running cpp build ?

@pirapira
Copy link
Member Author

pirapira commented May 9, 2018

Yes, that's not too bad. It doesn't take more than 20 minutes for pirapira/bamboo.

@winsvega
Copy link
Collaborator

winsvega commented May 9, 2018

like reverse test run?
how do you set a branch

@pirapira
Copy link
Member Author

pirapira commented May 9, 2018

In pirapira/bamboo it's always develop. Here, people need to change the Travis script so whomever/cpp-ethereum is checked out.

@winsvega
Copy link
Collaborator

winsvega commented May 9, 2018

and if it works they merge to develop?

@pirapira
Copy link
Member Author

pirapira commented May 9, 2018

ethereum/cpp-ethereum is like any other clients. They can choose to update the test and implement the changes.

@winsvega
Copy link
Collaborator

winsvega commented May 9, 2018

I mean the test develop branch contains actual tests. (the most updated ones)
if someone running testeth travis job on his own client and get is green. it does not mean it is ok to merge it into develop.

@pirapira
Copy link
Member Author

pirapira commented May 9, 2018

Right. We'll be also reading this somebody's client.

@winsvega
Copy link
Collaborator

winsvega commented May 9, 2018

is it that you want to remove travis job from cpp repository then?

@pirapira
Copy link
Member Author

pirapira commented May 9, 2018

No.

@winsvega
Copy link
Collaborator

winsvega commented Nov 5, 2020

outdated

@winsvega winsvega closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants