Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain 7672 #988

Merged
merged 11 commits into from
Apr 27, 2023
Merged

Add chain 7672 #988

merged 11 commits into from
Apr 27, 2023

Conversation

aidan-starke
Copy link
Contributor

@aidan-starke aidan-starke commented Apr 21, 2023

Add chain 7672 - The Root Network Porcini (Testnet)

View in Huly HI-722

@aidan-starke aidan-starke marked this pull request as ready for review April 21, 2023 02:24
@marcocastignoli
Copy link
Member

hi @aidan-starke, thanks for the contribution. Please follow the steps here https://docs.sourcify.dev/docs/chain-support/

In particular step 1.

Make sure the new chain is listed in chains.json but this file should not be edited. It is kept in sync with chainid.network (github: ethereum-lists/chains) periodically. If your chain is not included, please first add your chains to the ethereum-lists/chains repository first. The RPC node should be an archive node.

Thanks 🙂

This reverts commit 77ea8de.
@aidan-starke
Copy link
Contributor Author

Hi @marcocastignoli I updated the chains using the update-chains script as our networks are in ethereum-lists/chains but not in yours.

I have reverted that commit now

@marcocastignoli
Copy link
Member

Can you investigate why ci test "test-new-chain" is failing? thanks 🙏

@aidan-starke
Copy link
Contributor Author

@marcocastignoli the error message is Chain 7672 not supported! which I believe is due to chains.json not being in sync with ethereum-lists/chains

@kuzdogan
Copy link
Member

We've updated the chains.json. Can you merge from staging again?

@marcocastignoli
Copy link
Member

@marcocastignoli the error message is Chain 7672 not supported! which I believe is due to chains.json not being in sync with ethereum-lists/chains

Sorry, I tried to merge staging in this branch but I cannot push because of github permissions. Can you do it?

@kuzdogan kuzdogan merged commit 70e13de into ethereum:staging Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants