Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cronos Chain 25 #1049

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Conversation

crmax-it
Copy link
Contributor

@crmax-it crmax-it commented Jun 4, 2023

View in Huly HI-679

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.27 ⚠️

Comparison is base (3adb2c7) 77.31% compared to head (5eecf61) 70.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1049      +/-   ##
===========================================
- Coverage    77.31%   70.04%   -7.27%     
===========================================
  Files           31       40       +9     
  Lines         1450     2270     +820     
  Branches       266      432     +166     
===========================================
+ Hits          1121     1590     +469     
- Misses         191      465     +274     
- Partials       138      215      +77     
Flag Coverage Δ
lib-sourcify 66.70% <ø> (?)
server 71.93% <ø> (-5.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.94% <ø> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marcocastignoli
Copy link
Member

Hey @crmax-it, I see you updated the rpc filed in src/sourcify-chains.ts. Is it strictly necessary?

@crmax-it
Copy link
Contributor Author

crmax-it commented Jun 5, 2023

After checking it can be removed @marcocastignoli , removed it.

@marcocastignoli marcocastignoli merged commit b9547c6 into ethereum:staging Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants