Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui]: Give repo link on create2 lookup results #869

Closed
kuzdogan opened this issue Dec 12, 2022 · 5 comments
Closed

[ui]: Give repo link on create2 lookup results #869

kuzdogan opened this issue Dec 12, 2022 · 5 comments
Assignees
Labels
good first issue Issues to start contributing to the project if you're not familiar with the codebase

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Dec 12, 2022

The lookup results of create2 contracts currently does not include a link to the repo. Add a link to the repo as in other results

image

View in Huly HI-400

@kuzdogan kuzdogan added quick-fix good first issue Issues to start contributing to the project if you're not familiar with the codebase labels Dec 12, 2022
@uday03meh
Copy link

Hi,
Can someone please assign this to me?

@kuzdogan
Copy link
Member Author

Sure, there you go!

@Uttam-Singhh
Copy link
Contributor

Uttam-Singhh commented Jan 31, 2023

Hey @kuzdogan,
I would love to contribute here, I have a question:
When you say - ink to the repo you mean the button that says View in Sourcify Repository? right

Also I found this image in docs which shows the repo support -
sourcify-create2-lookup-f98344ee633fecc846a4c3b8a07aec1a

@marcocastignoli
Copy link
Member

marcocastignoli commented Feb 1, 2023

Hey @Uttam-Singhh, I love to see you here! Basically each chain in stored in the repo with its own chainId. (e.g. /contracts/full_match/CHAIN_ID/ADDRESS), create2 contracts are an exception because they are potentially not deployed on any chain (you can read more here: https://docs.sourcify.dev/docs/create2/). In the image you posted above the UI is telling you that the contract is in the repo in both /contracts/full_match/0/0x3957 and /contracts/full_match/1/0x3957, but only the link to /contracts/full_match/1/0x3957 is accessible via the link you mentioned above. We need a second link next to the create2 information

@marcocastignoli
Copy link
Member

@Uttam-Singhh hey! Do you have any updates regarding this? If not I will take this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues to start contributing to the project if you're not familiar with the codebase
Projects
None yet
Development

No branches or pull requests

4 participants