Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise "this" warning for constructors. #3877

Closed
ekpyron opened this issue Apr 13, 2018 · 2 comments
Closed

Revise "this" warning for constructors. #3877

ekpyron opened this issue Apr 13, 2018 · 2 comments
Labels
stale The issue/PR was marked as stale because it has been open for too long.

Comments

@ekpyron
Copy link
Member

ekpyron commented Apr 13, 2018

In #3875 the warning about the use of "this" in constructors was revised to reduce false positives.

However, now there are cases like C c = this; c.f(); that could be detected at compile-time, but are not warned about.

A general compile-time pure expression evaluator may help in detecting these cases.
@ekpyron ekpyron mentioned this issue Apr 13, 2018
Closed
@cameel
Copy link
Member

cameel commented Aug 3, 2021

Somewhat related issue: #11540.

@NunoFilipeSantos NunoFilipeSantos added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 25, 2022
@ekpyron
Copy link
Member Author

ekpyron commented Nov 29, 2022

Closing this - we may want to pick it up again after #13724.

@ekpyron ekpyron closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale The issue/PR was marked as stale because it has been open for too long.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cameel @ekpyron @NunoFilipeSantos