Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EIP155 #99

Closed
pipermerriam opened this issue Sep 25, 2017 · 2 comments
Closed

Implement EIP155 #99

pipermerriam opened this issue Sep 25, 2017 · 2 comments

Comments

@pipermerriam
Copy link
Member

Reference: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md

What is wrong?

In EIP155 transaction signature verification may include a chain ID which should be validated.

How can it be fixed

Use logic similar to this gist: https://gist.github.com/pipermerriam/38602f2ea4b2ebd762410f0afaa599d1
@pipermerriam
Copy link
Member Author

Test Vectors:

  • Raw-EIP155-txn for chain_id = 1: 0xf8640d843b9aca00830e57e0945b2063246f2191f18f2675cedb8b28102e957458018025a00c753084e5a8290219324c1a3a86d4064ded2d15979b1ea790734aaa2ceaafc1a0229ca4538106819fd3a5509dd383e8fe4b731c6870339556a5c06feb9cf330bb
    • Should recover to: 0xFeC2079e80465cc8C687fFF9EE6386ca447aFec4

@pipermerriam
Copy link
Member Author

replaced by https://github.com/pipermerriam/py-evm/issues/101

@ethereum ethereum deleted a comment from wjmelements Jul 25, 2018
pacrob pushed a commit to pacrob/py-evm that referenced this issue Dec 18, 2023
@reedsa
Merge pull request ethereum#99 from ethereum/release-check-upstream
fca6a3f 
Pre-release check for upstream configuration of remote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pipermerriam