-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for Python 3.7 #970
Comments
CircleCI does not yet provide machine images with pre-installed Python 3.7 stable release - only beta 5 and the release candidate. Watch docs or docker hub (linked from docs) for when those become available. EDIT: For a comparison between beta 5 and the RC - see Python's change log. |
Some dependencies might not yet support Python 3.7: see failed job:
EDIT: Arch Linux users are very likely to get hit with this first. See package page for when it enters For ref, I used this branch of mine. It requests the
EDIT: I'd say better wait for an image with 3.7 stable to avoid such shenanigans. |
The first exploratory steps of seeing what else is broken besides |
Summary: still waiting. Images with Python 3.7.0 (the stable version) have become available. I've made a new branch and directed it to use this new machine image, but there are still dependency problems. The After SSH'ing in and installing them, the build still fails, with same error as in wbolster/plyvel#62, i.e. because building Possible approaches:
(2) can get very brittle, so IMO best avoid it. |
We can probably open a PR to Alternatively, we've wanted to explore RocksDB (but I don't know if whatever python library sits on top of that supports 3.7 either) |
There is an issue with the Travis CI server and Python 3.7 but wheels can come before that |
It looks like plyvel 1.05 has been pushed with a py3.7 wheel |
Issue no longer blocked: I've had a successful CI job for Currently cleaning up that branch, will submit a PR. |
What is wrong?
Python 3.7 stable has been released: https://pythoninsider.blogspot.com/2018/06/python-3.html
We are not currently running any tests against it.
How can it be fixed
Start running the core tests against py3.7 in addition to the current python envs.
The text was updated successfully, but these errors were encountered: