-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethereum Core Devs Meeting 100 Agenda #221
Comments
Can we talk about responsible disclosure policies for consensus issues? We're downstream from geth, and would much appreciate hearing about consensus issues more quickly after the geth team learns of them. I'm sure other teams that maintain large infrastructure would appreciate it too |
I & @MadeofTin will be happy to give a walkthrough or answer any questions on the new |
I'd like to request some clarifications wrt EIP-2718. The spec explicitly wants to omit defining what different transaction types will be in the future and how the numbers are allocated:
This is of course fine as we don't know what the future holds, yet I do think it misses a crucial clarification, namely explicitly stating how legacy transactions behave. The spec talks about transactions in both a legacy format as well as a wrapped format. The moment you mention the latter, you need to explicitly define it. I think the idea was to have If the EIP does not want to define the wrapped version of legacy transactions, that's is fine, but then my request would be to explicitly mention it that clients implementing this EIP are still expected to fully only use the legacy format, and that and future wrapping will be defined in a future EIP and will explicitly spec the wire, RPC and consensus representation for them. My personal suggestion on that front is that maintaining both formats in the consensus format is insanity which will surely backfire when some client code does a weird conversion and goes out of consensus; so I'd vote to either use one or the other, but never both. |
I think there's a dissonance between 2930 and 2718. In 2930, I get the impression that the hash for a transaction is done by rlp-encoding into the hasher. Basically:
But the 2718 spec instead sounds like the correct way to hash it would be to hash it as a prefix + opaque blob. Basically:
(where [] means rlp-list) |
Closed in favor of #224 |
Ethereum Core Devs Meeting 100 (!!) Agenda
Agenda
Next call: November 27, 2020 14:00 UTC
The text was updated successfully, but these errors were encountered: