-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethereum Core Devs Meeting 84 Agenda #162
Comments
Some status updates:
|
I have signed off now. It looks great! Thanks, Martin @holiman |
Returning back to ethereum/EIPs#2046:
Bonus:
|
Could you add an agenda item for the EIPIP survey? |
I won’t be attending this week for EIPs in consideration for Berlin just Read through the list for awareness of what is being worked on. EIP-1962 and its BLS-Signature working group updates |
@shamatar to be fair I don't think merging a draft constitutes as confirmation that modexp is not relying on call costs Also on last ACD I mentioned I was working on a document trying to establish cost relationships, so we could reason for the reduction. I haven't gotten to any conclusion yet, but here is my working document: https://hackmd.io/@axic/rJPHqPywI |
I've made a new EIP PR: ethereum/EIPs#2583. File is here: https://github.com/ethereum/EIPs/blob/db1e389aae4e05654703d24862b0db91040bf745/EIPS/eip-draft-trie-penalty.md It implements a penalty-scheme, which is think is much needed at this point in time. If we have time, I would like to present it to the meeting, to get some initial feedback. Some of you have seen early copies of this eip, but it's been expanded since the initial conception, both in the EIP itself and the investigation into if/how it could disturb existing contracts. |
@shamatar all of what you conclude is only relevant for Parity, and might also be tied to some characteristics of your hardware. I will try to repro the benchmarks on geth, but I don't know what vectors ot use, so it would be good if you can publish them somewhere. Even if you generated them on the fly, perhaps you can spit out a relevant cross-section? As I see it, we're not even close to being able to draw any conclusions yet, but initial results look good. |
@holiman maybe it is worth considering the idea which was brought up as part of "Stateless Summit". Have a separate counter, this time for the entire transaction frame, for the penalty counting. This same counter could be used for witness size counting. Wouldn't it eliminate this attack vector? |
Vectors are randomly generated from seeded RNG. For hash functions it's just a random input into the string. For Blake2f I place random data everywhere and manually control number of rounds (first 4 bytes as BE encoding of uint32). For I believe that hardware dependent part is only a constant of 35_000_000 gas/second using |
Definitely maybe. But that idea can be done in several different ways, and depending on what path you go down, the effects on layer-2 can vary wildly. I'm open to exploring other ideas, but thought that my EIP suggestion above was about as good as I could make it, and wanted to publish it before moving on to exploring some other solution. |
Testing updates:
Testing questions:
|
@shamatar @holiman I would suggest that:
However it may be a lot of changes and it could make sense to restrict the number of repricings for this hard fork and roll out others later? |
Ethereum Core Devs Meeting 83 Notes |
Meeting notes for call 84. |
@Souptacular - Would it be possible to include https://eips.ethereum.org/EIPS/eip-2565 on the agenda for April 17. Thanks! |
Closed in favor of #164 |
Ethereum Core Devs Meeting 84 Agenda
Agenda
Next call: April 17, 2020 14:00 UTC
The text was updated successfully, but these errors were encountered: