fixing blobpool metrics name from - to _ for prometheus #27901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imulmat4
requested review from
karalabe,
holiman and
rjl493456442
as code owners
|
Ah, bummer. Ok, we can do that, thx |
fjl
pushed a commit
that referenced
this pull request
Aug 12, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27901)" This reverts commit e9a6ee6.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…thereum#27901)" This reverts commit e9a6ee6.
weiihann
pushed a commit
to weiihann/go-ethereum
that referenced
this pull request
Mar 13, 2024
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Mar 17, 2024
…m#27901) (#403) Co-authored-by: imulmat4 <[email protected]>
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
May 7, 2024
…m#27901) (#403) Co-authored-by: imulmat4 <[email protected]>
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
May 8, 2024
…m#27901) (#403) Co-authored-by: imulmat4 <[email protected]>
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
May 8, 2024
…m#27901) (#403) Co-authored-by: imulmat4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created this PR per #27900. I am running telegraf as a prometheus server and unable to scrape metrics because the blobpool metrics does not conform to Prometheus metrics naming standards. Please refer to https://prometheus.io/docs/practices/naming/.
All I am doing is changing the - to a _.
I tested and built this and my node was syncing and metrics names are still easily readable:
Apologies if I missed something here. First time open a PR in this repo.