Code

node: refactor package node#21105

Code

Merged

fjl merged 160 commits intoethereum:masterethereum/go-ethereum:masterfrom renaynay:draft-refactor-noderenaynay/go-ethereum:draft-refactor-nodeCopy head branch name to clipboardAug 3, 2020

+2,558-2,839

Commits

Commits on Aug 3, 2020

• created a new package node_2 where i am experimenting w/ interfaces and starting node

  

  renaynay

  authored and

  fjl

  committed
  3b2c927

• httpHandler -> httpServer

  

  renaynay

  authored and

  fjl

  committed
  d44ac53

• saving progress, working on ethstats impl

  

  renaynay

  authored and

  fjl

  committed
  ec0c791

• committing progress, eth.ethereum + les.lightethereum impl backend

  

  renaynay

  authored and

  fjl

  committed
  7f36098

• not working yet, but committing progress

  

  renaynay

  authored and

  fjl

  committed
  bc838a2

• fixed some registration for services

  

  renaynay

  authored and

  fjl

  committed
  a607196

• semi-functional impl

  

  renaynay

  authored and

  fjl

  committed
  c842bf8

• fixed dev mode start-up, should be working fine now

  

  renaynay

  authored and

  fjl

  committed
  8dbba60

• registerrpc and regiterprotocols

  

  renaynay

  authored and

  fjl

  committed
  2b67abf

• fixed RegisterLifecycle to be generic

  

  renaynay

  authored and

  fjl

  committed
  bf8a05b

• reverted capitalization of endpoint -- accident

  

  renaynay

  authored and

  fjl

  committed
  fc7bff8

• removed TODO

  Show description for ca32adf
  

  renaynay

  authored and

  fjl

  committed
  ca32adf

• remove unnecessary constructor types

  

  renaynay

  authored and

  fjl

  committed
  8290243

• fixes http/ws servers not being able to be started on given host/port

  

  renaynay

  authored and

  fjl

  committed
  95bc256

• registerHTTP but not w the signature felix suggested

  

  renaynay

  authored and

  fjl

  committed
  0ba43ec

• enable rpc/ws

  

  renaynay

  authored and

  fjl

  committed
  4985505

• changed RegisterHTTP and cleaned up some code, now gql can start on same port as http

  

  renaynay

  authored and

  fjl

  committed
  62ec847

• some clean up

  

  renaynay

  authored and

  fjl

  committed
  104ca9c

• changed console http startup

  

  renaynay

  authored and

  fjl

  committed
  6e53f68

• allow ws to be enabled on same port as http from console

  

  renaynay

  authored and

  fjl

  committed
  deb1a8c

• added todos

  

  renaynay

  authored and

  fjl

  committed
  06a8de8

• first steps implementing new design

  

  renaynay

  authored and

  fjl

  committed
  4dd45c9

• functional geth

  

  renaynay

  authored and

  fjl

  committed
  c4f1d63

• registering all apis

  

  renaynay

  authored and

  fjl

  committed
  e15007e

• added todo

  

  renaynay

  authored and

  fjl

  committed
  3993923

• removed todo

  

  renaynay

  authored and

  fjl

  committed
  0a3f9a2

• Register http (#16)

  Show description for 2888ca4
  

  renaynay

  authored and

  fjl

  committed
  2888ca4

• remove unnecessary RegisterHTTP method

  

  renaynay

  authored and

  fjl

  committed
  1f1bc0d

• added docs, removed err return from register lifecycle

  

  renaynay

  authored and

  fjl

  committed
  ae58c94

• HTTPServer implements Lifecycle and can be started by the lifecycle loop in node (#17)

  

  renaynay

  authored and

  fjl

  committed
  7acc43f

• removed unnecessary ListenerAddr

  

  renaynay

  authored and

  fjl

  committed
  35460fd

• stopServer removes stopped server from list of httpservers on node and also removes from list of lifecycles

  

  renaynay

  authored and

  fjl

  committed
  ccadac3

• starting to remove use of node.Service throughout codebase

  

  renaynay

  authored and

  fjl

  committed
  e3f2bd1

• WIP, trying to remove node.Service from tests

  

  renaynay

  authored and

  fjl

  committed
  1f5f52e

• fixes node tests (#18)

  

  renaynay

  authored and

  fjl

  committed
  5866e01

• http server array now a map (#19)

  

  renaynay

  authored and

  fjl

  committed
  1badd5d

• removed unnecessary change to pass host, port instead of endpoint

  

  renaynay

  authored and

  fjl

  committed
  fbc9a64

• added some more tests for http servers

  

  renaynay

  authored and

  fjl

  committed
  60ced1c

• moved some gql-specific tests to gql package

  

  renaynay

  authored and

  fjl

  committed
  53a2c8f

• removed todo

  

  renaynay

  authored and

  fjl

  committed
  331d0a6

• whisper tests working

  

  renaynay

  authored and

  fjl

  committed
  45eecce

• create a standalone whisper service for wnode purposes

  

  renaynay

  authored and

  fjl

  committed
  a380ff6

• p2p/simulations uses node.Lifecycle instead of node.Service (#21)

  

  renaynay

  authored and

  fjl

  committed
  076a9a5

• fixed mailserver tests

  

  renaynay

  authored and

  fjl

  committed
  3eb4fc8

• les tests passing

  

  renaynay

  authored and

  fjl

  committed
  6e41e41

• changes after rebasing on master, likely bc of serverpool pr

  

  renaynay

  authored and

  fjl

  committed
  2df58f7

• fixed p2p testing package

  

  renaynay

  authored and

  fjl

  committed
  fd6623e

• removing unnecessary methods and fixing todos

  

  renaynay

  authored and

  fjl

  committed
  ebde331

• removing more unnecessary methods

  

  renaynay

  authored and

  fjl

  committed
  06bf009

• instead of passing both les and eth explicitly, fetch backend from node

  

  renaynay

  authored and

  fjl

  committed
  4ce4c40

• typo

  

  renaynay

  authored and

  fjl

  committed
  cc3daf6

• fetch backend from service context rather than node since node isnt started yet

  

  renaynay

  authored and

  fjl

  committed
  3f132b5

• fixing some broken tests

  

  renaynay

  authored and

  fjl

  committed
  306f390

• linted

  

  renaynay

  authored and

  fjl

  committed
  fddc6bd

• not passing backends to startnode

  

  renaynay

  authored and

  fjl

  committed
  6c91bb4

• fixing docs

  

  renaynay

  authored and

  fjl

  committed
  5d67845

• fixed dao_test

  

  renaynay

  authored and

  fjl

  committed
  b8c5dc4

• lint

  

  renaynay

  authored and

  fjl

  committed
  885a7d4

• fixed current tests, but need to add more

  

  renaynay

  authored and

  fjl

  committed
  abbe6f8

• new test to check for proper creation of http servers on node

  

  renaynay

  authored and

  fjl

  committed
  ae92dee

• added more test coverage, removed some useless code

  

  renaynay

  authored and

  fjl

  committed
  f2fcf69

• minor changes, removing spaces, cleaninng up

  

  renaynay

  authored and

  fjl

  committed
  204514c

• some changes to graphql and other misc

  

  renaynay

  authored and

  fjl

  committed
  41a25c3

• linted

  

  renaynay

  authored and

  fjl

  committed
  666db04

• no need to pass gen state to makefullnode

  

  renaynay

  authored and

  fjl

  committed
  828646c

• missing register apis and protocols

  

  renaynay

  authored and

  fjl

  committed
  3443202

• register http before starting

  

  renaynay

  authored and

  fjl

  committed
  9ed169e

• added some documentation

  

  renaynay

  authored and

  fjl

  committed
  fb8e5b0

• minor fixes

  

  renaynay

  authored and

  fjl

  committed
  e897df9

• Changes requested from PR review (#23)

  

  renaynay

  authored and

  fjl

  committed
  cfae6ed

• attempt at fixing http test (#24)

  

  renaynay

  authored and

  fjl

  committed
  d49a5be

• fixed broken http test, waiting whether it passes on all builds

  

  renaynay

  authored and

  fjl

  committed
  52896ae

• use int32 instead of bool when checking whether to handle requests (#25)

  

  renaynay

  authored and

  fjl

  committed
  dce4780

• make sure to register all APIs when registering services apis on node

  

  renaynay

  authored and

  fjl

  committed
  0e7b866

• store int32

  

  renaynay

  authored and

  fjl

  committed
  a5204a4

• remove P2PServer method from les, unnecessary

  

  renaynay

  authored and

  fjl

  committed
  71d9590

• refactor http servers + graphql (#26)

  

  renaynay

  authored and

  fjl

  committed
  7661eb8

• removed some TODOs

  

  renaynay

  authored and

  fjl

  committed
  d96b280

• init leth handler

  

  renaynay

  authored and

  fjl

  committed
  ff002b1

• register protocols and apis of les on eth backend

  

  renaynay

  authored and

  fjl

  committed
  bafc12a

• node: make Node.Attach work before Node.Start

  fjl

  committed
  975061c

• all: excise SetContractBackend

  fjl

  committed
  8a568a4

• revert blackbox test for ethclient

  

  renaynay

  authored and

  fjl

  committed
  e930d38

• les: fix setOracle for chains without checkpoint

  fjl

  committed
  54b8389

• les --> lifecycle decoupled from ethbackend (#29)

  

  renaynay

  authored and

  fjl

  committed
  212bb78

• remove Fatalf from node, should panic instead

  

  renaynay

  authored and

  fjl

  committed
  1844d22

• eth: remove AddLesServer

  fjl

  committed
  a24c7b8

• cmd/utils: remove duplicate protocol/API registration

  fjl

  committed
  aaee36b

• remove newgqlhandler from rpcstack

  

  renaynay

  authored and

  fjl

  committed
  ebc7061

• node: stop lifecycles in reverse order

  fjl

  committed
  5d2e755

• node: simplify RegisterLifecycle

  fjl

  committed
  1b50b55

• donnt check ls

  

  renaynay

  authored and

  fjl

  committed
  489bb05

• Explicit type check for backend (#27)

  

  renaynay

  authored and

  fjl

  committed
  b2931b6

• go mod tidy

  

  renaynay

  authored and

  fjl

  committed
  e7602e3

• linted

  

  renaynay

  authored and

  fjl

  committed
  9ee9bbe

• changes requested by gary

  

  renaynay

  authored and

  fjl

  committed
  b26ea83

• node: unexport CreateHTTPServer

  fjl

  committed
  dd06152

• graphql: don't check for HTTP server creation

  Show description for 57ffd7c
  fjl

  committed
  57ffd7c

• node: unexport ExistingHTTPServer

  fjl

  committed
  c8b01c4

• node: add new lifecycle docs

  fjl

  committed
  783ad61

• node: fix comment on Start

  fjl

  committed
  af82314

• node: move datadir cleanup from Stop to Close

  fjl

  committed
  33ffe5b

• node: simplify stop channel

  fjl

  committed
  767e3b1

• node: remove Stop

  Show description for ce38ec6
  fjl

  committed
  ce38ec6

• all: Node.Stop -> Node.Close

  fjl

  committed
  cd46fce

• mobile: add TODO for restart

  fjl

  committed
  d2c2474

• node: add more runstate checks

  fjl

  committed
  4fdd72b

• node: ensure Register* can only be used in initializing state

  fjl

  committed
  068fe78

• removed unnecessary use of fmt.Sprintf

  

  renaynay

  authored and

  fjl

  committed
  81ecb44

• revert accidental q

  

  renaynay

  authored and

  fjl

  committed
  0ea3bb4

• fixed ethstats backend interface

  

  renaynay

  authored and

  fjl

  committed
  f3f1178

• node: whitespace changes

  fjl

  committed
  3c0fb99

• p2p/simulations/adapters: use Node.Attach where possible

  fjl

  committed
  7801fad

• node: avoid setting server to nil

  fjl

  committed
  d4e2173

• node: use simple lock

  fjl

  committed
  dab27f6

• node: more cosmetic fixes

  fjl

  committed
  b8d7587

• node: track open databases

  fjl

  committed
  b6c60cf

• core/rawdb: make Freezer.Close idempotent

  fjl

  committed
  4ae4172

• node: avoid auto-closing DB if service closes it first

  fjl

  committed
  8400a5d

• p2p/simulations/adapters: delete snapshotService

  fjl

  committed
  fa88f30

• p2p: delete Server.Running

  fjl

  committed
  4da9ef7

• cmd/geth, cmd/utils: gofmt -w -s

  fjl

  committed
  e1f4668

• p2p/simulations/examples: remove unused APIs callback

  fjl

  committed
  a30d401

• p2p/testing: delete unused package

  Show description for 5a3cf7a
  fjl

  committed
  5a3cf7a

• node: unexport RegisterHTTPServer

  fjl

  committed
  e6cd0e3

• node: clean up instrumented service tests

  fjl

  committed
  aba0667

• node: add test for database auto-closing

  fjl

  committed
  a23b650

• node: WIP TestNodeOpenDatabaseFromLifecycle

  Show description for 0a5312a
  fjl

  committed
  0a5312a

• node: move Start up

  fjl

  committed
  39dbf65

• node: simplify Start/Stop concurrency handling

  fjl

  committed
  6a16cbe

• node: unexport built-in API handler objects

  fjl

  committed
  cc9fddd

• node: move RegisterApisFromWhitelist

  fjl

  committed
  390e8a3

• miner: fix test scripts

  fjl

  committed
  908268d

• miner: simplify test scripts

  fjl

  committed
  891b286

• miner: simplify test scripts even more

  fjl

  committed
  c70d5e6

• node: remove atomic operations on n.state

  fjl

  committed
  45f162c

• node: WIP rewrite HTTP server setup

  Show description for 4a6faff
  fjl

  committed
  4a6faff

• descriptive logging

  

  renaynay

  authored and

  fjl

  committed
  a1a4454

• removed ws log

  

  renaynay

  authored and

  fjl

  committed
  2d81929

• node: add test for StartRPC API

  fjl

  committed
  c985bd4

• node: fix test

  fjl

  committed
  f2dbf7e

• node: delete redundant websocket enabling test

  fjl

  committed
  47315c0

• node: fix all the HTTP server API tests

  fjl

  committed
  9a1131c

• node: improve comments

  fjl

  committed
  6d544c6

• node: fix starting RPC after it failed to listen

  fjl

  committed
  d7c1258

• changed node tests

  

  renaynay

  authored and

  fjl

  committed
  b8b1046

• rpcstack tests

  

  renaynay

  authored and

  fjl

  committed
  8580962

• linted and new tests

  

  renaynay

  authored and

  fjl

  committed
  68cc90c

• reshuffling some funcs in rpcstack

  

  renaynay

  authored and

  fjl

  committed
  917135f

• node: move disableWS down as well

  fjl

  committed
  3664dd5

• node: improve comments

  fjl

  committed
  de11bb1

• go.mod: revert dependency updates

  fjl

  committed
  98cf053

• eth: fix compile issue in backend.go

  fjl

  committed
  b265e2c

• node: fix IPC API registration

  fjl

  committed
  1c639bd

• graphql: fix test

  fjl

  committed
  e11bc43

• node: remove blank line

  fjl

  committed
  f1b1b33

• node: sort+dedup logged HTTP handlers

  fjl

  committed
  3001cf5

• node: fix lint issue

  fjl

  committed
  4d42e9f

• node: rename RegisterPath -> RegisterHandler

  Show description for 2b5bd5e
  fjl

  committed
  2b5bd5e

• node: explain RegisterHandler 'name' parameter in docs

  fjl

  committed
  74e2aa9