Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm, params: implement EIP2200, SSTORE optimizations #19964

Merged
merged 2 commits into from
Aug 19, 2019
Merged

core/vm, params: implement EIP2200, SSTORE optimizations #19964

merged 2 commits into from
Aug 19, 2019

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Aug 14, 2019 •
edited
Loading

No description provided.

@karalabe karalabe added this to the 1.9.3 milestone Aug 14, 2019
@karalabe karalabe mentioned this pull request Aug 14, 2019
Merged
holiman
holiman approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me, and primarily I'm certain it will not screw with anything. Whether it is correct or not is better left for testing, which this PR enables us to do. So I approve

@karalabe karalabe mentioned this pull request Aug 15, 2019
Closed
10 tasks
holiman
holiman approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rjl493456442
rjl493456442 approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least it's consistent with EIP

@karalabe karalabe merged commit 3bb9b49 into ethereum:master Aug 19, 2019
This was referenced Sep 3, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@karalabe @holiman @rjl493456442