Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appveyor.yml: Upgrade to go1.12.2 #19405

Merged
merged 2 commits into from
Apr 8, 2019
Merged

appveyor.yml: Upgrade to go1.12.2 #19405

merged 2 commits into from
Apr 8, 2019

Conversation

SamuelMarks
Copy link
Contributor

@karalabe karalabe added this to the 1.9.0 milestone Apr 6, 2019
karalabe
karalabe approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@karalabe
Copy link
Member

karalabe commented Apr 6, 2019

Wow, 1.12.2 is bloooooown up on Linux

@hackmod
Copy link
Contributor

hackmod commented Apr 7, 2019

Wow, 1.12.2 is bloooooown up on Linux

I guess you already know, s/trusty/xenial/g fix this issue.

see also golang/go#31293 (comment)

@karalabe karalabe merged commit 78644f0 into ethereum:master Apr 8, 2019
@SamuelMarks SamuelMarks deleted the go1.12.2 branch April 9, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelMarks @karalabe @hackmod