eth, les: Consider context errors in vmError function #19196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an `eth_call` request, if the EVM processing takes > 5 seconds
the request gets cancelled, but this is not resulting in an error
to the `eth_call` request (instead it responds with a result of "0x"
regardless of the called function).
With this in place, when a request times out, it will return an error
of:
`"error":{"code":-32000,"message":"context deadline exceeded"}`
Rather than incorrectly returning a null value.
|
I'm not certain due to the lack of detail in the other issue, but I believe this is will solve #19186 |
|
It looks like the appveyor build failure is also failing on master. I'm pretty sure it's not related to my changes - if you think it is let me know and I'll look into it. |
|
Have you ever tried this PR #19737? |
|
This seems to have already been fixed upstream. Please check and if not, we can reopen it. |
|
Presumably fixed by #19737 If not, please reopen this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an
eth_callrequest, if the EVM processing takes > 5 secondsthe request gets cancelled, but this is not resulting in an error
to the
eth_callrequest (instead it responds with a result of "0x"regardless of the called function).
With this in place, when a request times out, it will return an error
of:
"error":{"code":-32000,"message":"context deadline exceeded"}Rather than incorrectly returning a null value.