accounts/abi, mobile: use EIP155Signer for new txs (#16484)

[dinstein]

Fix #16484.

[karalabe]

I'm a bit uncertain about this change. If we have the SignerFn already supplied from the outside, why not add the EIP155 changes to that instead? This PR feels as if we're leaking out logic into the wrong place.

[dinstein]

I thought the ChainId may be an attribute of transaction (just like Nonce) after EIP155 hard fork, so I added it into TransactOpts. While if we treat it as an attribute of SignFn, indeed it should not be included in TransactOpts.

SignFn requires a types.Signer input parameter, but without ChainId we could not create an EIP155 Signer in transact function either pass it to SignFn, so shall we implement a SignFn that ignore the first parameter types.Signer and create an EIP155 Signer inside instead?

[dinstein]

As shown in mobile/bind.go, the SetSigner create an opts.Signer which ignores the input parameter signer and uses mobile.Signer to sign a txn. I think this may be a little confusing, if we want SignFn to handle all the signing actions, maybe we should remove its first parameter types.Signer and only pass address and unsigned txn to it.

[Dominator008]

What's the status of this?

[gballet]

@dinstein you are right, having the signer as the first parameter leads to a confusing situation. Removing the first parameter is a good idea. It will require a change in NewKeyedTransactor but it's easily done with that SetSigner function.

[dinstein]

@gballet glad to see the progress :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.