Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking eth_feeHistory API change in v1.11.0+ #26751

Closed
michaelkaplan13 opened this issue Feb 21, 2023 · 1 comment · Fixed by #26758
Closed

Breaking eth_feeHistory API change in v1.11.0+ #26751

michaelkaplan13 opened this issue Feb 21, 2023 · 1 comment · Fixed by #26758
Labels

Comments

@michaelkaplan13
Copy link

There was a minor breaking change to the eth_feeHistory API introduced in v1.11.0.

Specifically in the this commit: 31d401e

Previously the blockCount parameter could be given as a number in JSON; now it must be given as a string.

This request body was previously valid:

{
    "jsonrpc": "2.0",
    "method": "eth_feeHistory",
    "params": [1, "latest", []],
    "id": 42
}

But now gives the error: invalid argument 0: json: cannot unmarshal number into Go value of type *math.HexOrDecimal64

It's a simple change, but it would be helpful to call this out in the release notes so any client implementations will know they need to make the change prior to upgrading.

@Moha19med88
Copy link

#26793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants