-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We can retrieve leveldb stats more directly? #25116
Comments
I guess the total wasn't part of the output when we've implemented this, at least looking at the example output in the exact code you linked. |
And something irrelevant, Leveldb now supports to report stats in a single structure. Instead of parsing the stats in string format, it can be definitely easier. I guess it could be a starter task anyway. |
Though if we go with Pebble in the long term, might not be worth to poke working code. |
yeah, I think we can do smth like this? |
Since we've switched the default over to pebble, we're not going to further work on leveldb integration |
Why we don't get the db stats directly from the Total line in the current leveldb output below?
Instead of accumulating the data from the lines like current code?
go-ethereum/ethdb/leveldb/leveldb.go
Line 268 in 01e5e9c
The text was updated successfully, but these errors were encountered: