Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Prometheus metrics #17086

Closed
chapsuk opened this issue Jun 26, 2018 · 1 comment
Closed

Proposal: Prometheus metrics #17086

chapsuk opened this issue Jun 26, 2018 · 1 comment

Comments

@chapsuk
Copy link
Contributor

chapsuk commented Jun 26, 2018

Description

Now metrics collecting in internal metrics.Registry and can be pushed to external influxdb.
I suggest adding support for prometheus pull metrics.

Changes

  • add prometheus http server for expose metrics;
  • format internal metrics to prometheus format

Types mapping

geth prometheus description
counter gauage geth counter can be decremented, prometheus counter not
gauage gauage
gauageFloat64 gauage
metr counter expose only count metric, prometheus aggregations or rates
timer summary expose counter and percentiles, min/max/mean aggregations on prometheus side
resettingTImer summary

Implementation

For implement expose metrics i'm not use official prometheus client to avoid duplicate metrics aggregation.
I considered the option with the implementation of the metrics.Registry interface, but due to the different types and approach to aggregating metrics, this option did not look friendly.

#17077

Example of grafana dashboard with geth metrics collected by prometheus:
https://snapshot.raintank.io/dashboard/snapshot/nxZB4UEhyo2zvMZNzBUfb7jlTAnE57fF?orgId=2 -

@chapsuk
Copy link
Contributor Author

chapsuk commented Apr 11, 2019

#17077 🎉 🌮

@chapsuk chapsuk closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant