Implement EIP-7610 #999
Merged
Implement EIP-7610 #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
Sep 12, 2024
src/ethereum/berlin/state.py
Outdated
Comment on lines
371
to
372
| if address in state._storage_tries: | ||
| return True |
There was a problem hiding this comment.
Would it make sense to introduce a has_storage(state: State, address: Address) function?
Either way, I think we need to modify the ethereum_optimized monkey patches, since that implementation doesn't have _storage_tries.
Adding and patching a has_storage function (instead of patching account_has_code_or_nonce_or_storage) would probably mean less code in ethereum_optimized, which is usually good.
There was a problem hiding this comment.
Have introduced the has_storage function. Haven't implemented any updates to the optimized implementation but made a note in the post-prague re-factoring issue #948
gurukamath
force-pushed
the
eip-7610
branch
from
5b0088e
to
7b15c68
Compare
SamWilsn
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
EIP-7610 is not implemented currently.
How was it fixed?
Implement EIP-7610
Cute Animal Picture