Ban post merge empty accounts in tests #853
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertdavies
force-pushed
the
ban-post-merge-empty-accounts
branch
from
9a2cc26
to
45f45bc
Compare
|
My bad for not reviewing this sooner! Is this still in a good state to go through? |
Unfortunately, I think there are some Cancun related tests with empty accounts in them. |
|
Alright, ping me on Discord when this is ready to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bans post merge empty accounts in tests in preparation for EIP-7523. Any test that contains such accounts will fail during loading.
Currently a large number of tests fail this check, they need to be removed. Once tests have been fixed this can be made non-draft and merged.
Cute Animal Picture