Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction's nonce should be of type U64 #986

Open
SamWilsn opened this issue Aug 14, 2024 · 5 comments · May be fixed by #995
Open

Transaction's nonce should be of type U64 #986

SamWilsn opened this issue Aug 14, 2024 · 5 comments · May be fixed by #995
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers

Comments

@SamWilsn
Copy link
Contributor

Because of EIP-2671, the nonce of a transaction is limited in size to fit in a U64. We currently use a U256:

execution-specs/src/ethereum/cancun/transactions.py

Line 37 in fcd1275

nonce: U256

@SamWilsn SamWilsn added A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers labels Aug 14, 2024
@richardgreg
Copy link
Contributor

Should the change apply to every instance of U256 in the repo?

@richardgreg richardgreg linked a pull request Aug 23, 2024 that will close this issue
Open
@Nanle100
Copy link

can i work on this

@SamWilsn
Copy link
Contributor Author

Should the change apply to every instance of U256 in the repo?

No, just transaction nonces

can i work on this

Go for it! We're happy to have outside contributors.

@SamWilsn
Copy link
Contributor Author

Do note that @richardgreg already has a pull request up though: #995

@SamWilsn
Copy link
Contributor Author

I'm actually going to merge that pull request, so probably best to not duplicate work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-spec Area: specification C-enhance Category: a request for an improvement E-easy Experience: easy, good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Transaction nonce to U64 richardgreg/execution-specs
4 participants
@richardgreg @gurukamath @SamWilsn @Nanle100