EIP-2681: Limit account nonce to 2^64-1

[axic]

EIP-2681 applies from genesis. It was properly merged into Geth this week and also the state tests repository has it merged.

[gurukamath]

Which test cases would one use to build this? I am unable to find any JSON under tests that mentions this issue.

[SamWilsn]

Which test cases would one use to build this? I am unable to find any JSON under tests that mentions this issue.

They can be found in the upstream repository: https://github.com/ethereum/tests/tree/develop/TransactionTests/ttNonce

The tests/fixtures directory is a submodule, and needs to be updated to get the latest tests.

[gurukamath]

@SamWilsn Thanks.

Also for the other change mentioned in EIP-2681
"The CREATE and CREATE2 instructions to abort with an exceptional halt, where the account nonce is 2^64-1", I assume the relevant test is High Nonce Test.

However, I see that the structure of the above JSON is quite different from the fixtures that have been tested so far for the VM System Operations (I looked at suicide0 as a reference). For example, the "exec" key from the old JSON is missing in the new one (perhaps replaced by "transaction" based on a quick glance).

Is there any reference that could help me load the new format of tests? Or at least a dictionary that translates the old keys in JSON to the new one?

[lightclient]

@gurukamath what you are seeing is the difference between the "state" tests, "blockchain" tests, and "transaction" tests. The state tests are essentially a subset of blockchain tests and have been discontinued. The transaction tests validate the static aspects of rlp encoded transactions (more info here). There really isn't a concept of a "transaction test validator" yet in the execution spec, so you'd need to implement something. But it should be straightforward - it should decode the rlp to a transaction object and determine if any exceptions were raise (e.g. nonce too large) and if the tx valid, it verifies the hash and a few other components.

[gurukamath]

@lightclient Thanks for the information.
I have managed to implement the static transaction test validator on my local feature branch to test that the transaction nonce is too large.

I am however, having trouble with the second point of EIP-2681 where I need to pass a transaction with high nonce through the VM and make sure that the CREATE instruction aborts with exceptional halt. I am trying to draw parallels between the already implemented vm system tests (for example suicide0) and High Nonce, but am having trouble mapping the two JSON structures