Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid fork name ShanghaiToCancunAtTime15k in state_tests. #405

Closed
chfast opened this issue Jan 26, 2024 · 1 comment · Fixed by #406
Closed

Invalid fork name ShanghaiToCancunAtTime15k in state_tests. #405

chfast opened this issue Jan 26, 2024 · 1 comment · Fixed by #406

Comments

@chfast
Copy link
Member

chfast commented Jan 26, 2024

The ShanghaiToCancunAtTime15k is invalid fork name in a StateTest because they execute single transaction/block. You need to pick Shanghai or Cancun during test generation.

@marioevz
Copy link
Member

Upon taking a look of the tests that do this:

  • test_blob_type_tx_pre_fork
  • test_point_evaluation_precompile_before_fork
  • test_blobbasefee_before_fork

The idea behind these tests was that, on the blockchain-test version, the fork configuration contains the scheduled upcoming fork.

So it might be worth it to do the fix as you suggested on discord, where we pass the fork that is enabled according to the block timestamp and number to the state test, while we use the transition fork for the blockchain test version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants