Test for EIP-663 with jumpdest #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 93.46% 94.82% +1.35%
==========================================
Files 18 18
Lines 1866 1950 +84
Branches 197 202 +5
==========================================
+ Hits 1744 1849 +105
+ Misses 97 76 -21
Partials 25 25 |
|
Can you extract your tests from this PR to merge them? |
|
@chfast They can't be merged to |
Just use |
jwasinger
pushed a commit
to jwasinger/evmone
that referenced
this pull request
Apr 27, 2021
AppVeyor fixes
|
Can I close this? |
Fine by me. |
|
Obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a test on top of EIP-663 implementation for the problem called out by @chriseth in https://ethereum-magicians.org/t/eip-663-unlimited-swap-and-dup-instructions/3346/10
Basically some JUMPDESTs that were considered valid before EIP-663, with it are considered a part of the multibyte opcode and not a JUMPDEST. So some old contracts might be broken.