Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evmc_execute should take evmc_tx_context as an parameter #120

Open
axic opened this issue Aug 31, 2018 · 3 comments
Open

evmc_execute should take evmc_tx_context as an parameter #120

axic opened this issue Aug 31, 2018 · 3 comments

Comments

@axic
Copy link
Member

axic commented Aug 31, 2018

I think all those execution details should be available to the client prior to execution. Do you think any client can be savings by assuming the code will not need those and only lazily populate evmc_tx_context on the first call to to get_tx_context?

@chfast
Copy link
Member

chfast commented Aug 31, 2018

This comes down to ethereum/evmjit#110.

@axic
Copy link
Member Author

axic commented Sep 5, 2018

Potentially this may want to be benchmarked and as such would be postponed to ABIv7.

@chfast
Copy link
Member

chfast commented Aug 5, 2019

I believe it is good change. It saves us trouble caching this on VM side.
Also, this can be handled very efficiently on the Host side - it requires to create the tx_context once per block, and then update the 2 fields than depend on transaction. If you process transactions in parallel, you need multiple copies per execution thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants