Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge updates from the python project template #96

Merged
merged 201 commits into from
Jan 10, 2024
Merged

Merge updates from the python project template #96

merged 201 commits into from
Jan 10, 2024

Conversation

pacrob
Copy link
Collaborator

@pacrob pacrob commented Dec 20, 2023 •
edited
Loading

What was wrong?

Joining this repo with the python project template. Notable changes:

  • drop python 3.6 and 3.7 support
  • add python 3.11 support
  • use pre-commit for linting
  • change the name of the master branch to main
  • drop tests for coincurve<12 , as 12 is the first version to support python 3.8
  • add tests for coincurve up to the current v18

Cute Animal Picture

image

carver added 30 commits January 24, 2018 16:00
@carver
init
a7955a5
@carver
Replace all template vars
3d87ff7
@carver
skip replacing variables inside .git/* files
cdba56a
@carver
create empty module with supplied name
9cdfd64
@carver
shorten extra name for documentation install
4a8b7b0
@carver
start at devnum 0 so the first bump goes to 1
ca670f4
@carver
add docs index
1d4e19d
@carver
add github templates for issues and pull requests
3290919
@carver
Link to dev tactical manual
2938497
@carver
add make lint-roll to locally auto de-lint
76bfefa
@carver
docs cleanup: Makefile, conf, warnings
195249c
@carver
requirements.txt: best way to build on readthedocs
109a086
@carver
bugfix: run tox -elint *after* isort
96a3717 
otherwise tox fails, and the auto-lint never runs
@carver
when do you not want ipython in local dev? never
0e57d8e
@carver
pytest default settings, plus pytest-watch
9a7d72a
@carver
add circle ci config
cb71fb4
@carver
fixups: rm template filler, xfail strict, make bug
f7b0f07
@carver
add badges: pypi version and pythons supported
4bb4f72
@carver
docs: show badge, link to release notes
b825c36
@carver
add pypy3 as a supported environment, by default
7bfa2ac
@carver
add module import test
6abf066
@carver
bugfix: setuptools reference to pypy
1695a3b
@carver
silence flake8 error during module import test
beb1b10
@carver
add doctest by default
a9d9fec
@carver
every tox environment should have a basic python
a1ba89e
@carver
squash warning about using make inside tox
37d978c
@carver
can't override python that way in tox
ecb3731
@carver
add doctest run to travis
60b026e
@carver
add doctest run to circle-ci
5890203
@carver
tox.ini bugfix: whitelist make
b3461e9
pacrob and others added 11 commits October 27, 2023 12:40
@pacrob
condense tox lint envs as linting now a pre-commit call, not tox
885bef7
@fselmo
update the grep command for upstream branch check
3c65483 
- Sometimes 'www.' is used in the url for https
@fselmo
Use upcoming version in make notes commit
7f75b27
@fselmo
Merge pull request #112 from fselmo/update-upstream-check-grep
d2a0901 
Makefile updates
@fselmo
Further generalize the grep command for remote check
4d17820
@reedsa
Ignore all __pycache__ directories (#114)
67c0fb4 
* Ignore all __pycache__ directories

* Newsfragment

* Revert Newsfragment
@pacrob
add formats key to RTD to make downloadable docs available
0b05938
@pacrob
add .bumpversion.cfg to pre-commit ignore
d1395aa 
Causes problems with releasing when pre-commit changes the file after bumpversion updates it
@pacrob
add pyupgrade to pre-commit hooks
621cd56
@pacrob
move pyupgrade before black
cb3f556
@pacrob
merge template and fill template variables
c96ce5b
@pacrob pacrob force-pushed the upgrade-template branch 4 times, most recently from e61d240 to fb76f81 Compare December 21, 2023 18:40
pacrob
pacrob commented Jan 3, 2024
View reviewed changes
eth_keys/backends/coincurve.py
signature_bytes = signature.to_bytes()
try:
public_key_bytes = self.keys.PublicKey.from_signature_and_message(
signature_bytes,
msg_hash,
hasher=None,
).format(compressed=False)[1:]
except (ValueError, Exception) as err:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ValueError is an Exception, so catching both is redundant.

@pacrob pacrob force-pushed the upgrade-template branch 5 times, most recently from ee8082c to 3b06e4f Compare January 3, 2024 19:14
@pacrob pacrob requested review from kclowes, reedsa and fselmo January 3, 2024 19:23
reedsa
reedsa approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pacrob pacrob merged commit 563678a into ethereum:main Jan 10, 2024
30 checks passed
@pacrob pacrob deleted the upgrade-template branch January 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

@kclowes kclowes Awaiting requested review from kclowes

@fselmo fselmo Awaiting requested review from fselmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.