fix default value in compute_domain #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlBeek
reviewed
Jan 22, 2020
Co-Authored-By: Carl Beekhuizen <[email protected]>
djrtwo
force-pushed
the
fix-default-compute-domain
branch
from
a8a8018 to
e821476
Compare
protolambda
approved these changes
Jan 22, 2020
| """ | ||
| Return the domain for the ``domain_type`` and ``fork_version``. | ||
| """ | ||
| if fork_version is None: |
There was a problem hiding this comment.
Looks good, however, with the new phase 1 changes the module is reloaded fully, instead of just reloading variables and type declarations. So this wouldn't be a problem in the future. Still think it is better practice to do this, and v0.10.1 needs it, so LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1582
Default value being passed into
compute_domainwas not being overridden when using alternative configuration files. Instead, default toNoneand conditionally set the variable ifNoneto ensure get most updated version of config varThanks @benjaminion for reporting and solving the problem here!