Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Get Aleth working with retesteth #5779

Open
halfalicious opened this issue Oct 15, 2019 · 7 comments
Open

Get Aleth working with retesteth #5779

halfalicious opened this issue Oct 15, 2019 · 7 comments
Assignees
Labels
test Test-related work

Comments

@halfalicious
Copy link
Contributor

halfalicious commented Oct 15, 2019

@gumb0 Reported that Aleth doesn't work with retesteth and that this needs to be investigated and fixed.

@halfalicious halfalicious added the test Test-related work label Oct 15, 2019
@gumb0
Copy link
Member

gumb0 commented Oct 22, 2019

@winsvega your input would be useful here

@gumb0 gumb0 self-assigned this Nov 12, 2019
@gumb0
Copy link
Member

gumb0 commented Nov 12, 2019

I tried running state tests with retesteth in "alethIPCDebug" mode - that is, when retesteth connects to already running client via IPC socket.

It required changes in some configs ethereum/tests#656
Then many tests pass, but precompile-related ones fail because of the issue in retesteth ethereum/retesteth#60
Also, aleth incorrectly answers debug_accountRangeAt #5815 but that is a problem only when running retesteth with high log verbosity.

@gumb0
Copy link
Member

gumb0 commented Nov 13, 2019

Another fix in configs needed: ethereum/tests#659

And another issue in aleth affecting running tests around precompiles #5819

@gumb0
Copy link
Member

gumb0 commented Nov 18, 2019

Another fix in configs needed: ethereum/tests#660

@gumb0
Copy link
Member

gumb0 commented Nov 18, 2019

Another fix in configs needed to fix CHAINID test failure ethereum/tests#661

@gumb0
Copy link
Member

gumb0 commented Nov 21, 2019

With the fixes to configs above the only errors left are caused by ethereum/retesteth#60

I have tried so far only running the state tests and only in IPC-attach mode. There are still many things more we could try:

  • Runnning blockchain tests
  • Generating the tests
  • Running in HTTP mode with dopple
  • Running in the mode where retesteth starts aleth process(es)
  • Running with retesteth in docker

@winsvega
Copy link
Contributor

This commands should run without errors:
-t GeneralStateTests
-t GeneralStateTests --filltests
-t GeneralStateTests --filltests --fillchain

-t BlockchainTests could throw some errors. the blockchain test generation works only for ValidBlocks.

TransitionTests does not work on geth. Might be configuration issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test Test-related work
Projects
None yet
Development

No branches or pull requests

3 participants