Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Hardfork Meta - Pectra #8121
Add EIP: Hardfork Meta - Pectra #8121
Changes from 6 commits
82021cd
afd82d4
a7c862b
80548bf
f744e56
9654304
d2bbca8
db62e8a
16148c0
f47300b
18e1216
51ab6f4
4751ce4
c0e5b52
9ffd729
d68d128
6085cf3
a5458b1
a760c7b
b8e4ca4
8089019
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale section should justify decisions made within the EIP, not the EIP as a whole. Unless you actually want to explain why these particular EIPs are being included, I think you should just omit this section as it doesn't really make sense. Would require an override on the bots though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My last two Meta EIPs had such rationales, but I'm happy with whatever. Feels simpler to not have to override the bot all the time, but also OK to delete this.
For reference: