EIP 808 - ERC for a Standard Decentralized Booking Protocol #808

appyhour770 · 2017-12-26T21:33:03Z

EIP 808 - ERC for a Standard Decentralized Booking Protocol

pirapira · 2018-01-02T11:35:24Z

Please use the number 808 instead of 770. (The convention is to use the issue number or a PR number in this repository, and #770 is already a PR about something else).

I'll review this today or tomorrow.

pirapira · 2018-01-02T11:36:26Z

EIPS/eip-770.md

+
+## Abstract
+
+The following describes standard functions for a decentralized booking protocol that can be used to reserve any kind of resource (Hotel, concert ticket, restaurant table).


Hotel-->hotel room?

Yes, hotel room

pirapira · 2018-01-02T11:36:59Z

EIPS/eip-770.md

+    Category : ERC
+    Status: Draft
+    Created: 2017-12-26
+    Requires : ERC 20


An extra space before :.

Requires: 20
should be fine.

Will be done in next submission

pirapira · 2018-01-02T14:17:36Z

EIPS/eip-770.md

+
+(Step 6.2 - Optional) Provider cancels the reservation by broadcasting a cancellation request. This triggers a submission to the RES smart contract that empties the registries for this resource. RES smart contract is releasing the escrowed amount to booker.
+
+(Step 7.1 & 7.2) Booker is notifying that the resource has been paid (presumably at resource check-out). RES smart contract is releasing the escrowed BTU back to user in addition to a BTU agreed commision.


Spelling: commision should be commission.

To be fixed in next submission

pirapira · 2018-01-02T14:33:45Z

EIPS/eip-770.md

+
+## Motivation
+
+The Booking Token Unit (BTU) protocol is a building block for any decentralized application (dApp) or web site willing to implement booking features for their end-users.


Is the name of the protocol

The Booking Token Unit protocol, or

Decentralized Booking Protocol?

If these two are different protocols, where is the Booking Token Unit protocol described?

There is only one protocol, the "Booking Token Unit protocol" that is the subject of this ERC

The title reads differently.

Title was not meant to name the protocol, but thanks for this valuable feedback, I adjusting the title accordingly

pirapira · 2018-01-02T14:34:10Z

EIPS/eip-770.md

+
+The Booking Token Unit (BTU) protocol is a building block for any decentralized application (dApp) or web site willing to implement booking features for their end-users.
+This standard also brings interoperability among decentralized applications that incorporate it.
+We strongly believe that a  transparent and public inventory enabled by an open-source standardized protocol would considerably lower the entry barriers to many Internet booking markets.


An extra space after a.

Will be fixed in next submission

pirapira · 2018-01-02T14:36:00Z

EIPS/eip-770.md

+
+The BTU protocol involves potentially ten steps and our standardized decentralized reservation contract (RES). Some of following steps can be relayed off-chain, but are always settled on-chain.
+
+<img src="./eip-770/protocol-steps.png">


The image contains an Ethereum logo. Ethereum logos are distributed under Creative Commons Attribution 3.0. Please follow the term of the license.

Thanks for this reminder that will be taken into account in next submission

pirapira · 2018-01-02T14:36:16Z

EIPS/eip-770.md

+
+<img src="./eip-770/protocol-steps.png">
+
+Hereafter the general sequence :


An extra space before :.

Will be fixed in next submission

pirapira · 2018-01-02T14:37:23Z

EIPS/eip-770.md

+
+(Step 7.1 & 7.2) Booker is notifying that the resource has been paid (presumably at resource check-out). RES smart contract is releasing the escrowed BTU back to user in addition to a BTU agreed commision.
+
+## Implementation


The implementation section is supposed to contain links to testable code.

pirapira · 2018-01-02T14:38:05Z

EIPS/eip-770.md

+	BookingStatus    _bookingStatus ; // reservation status
+	string                  _metaDataLink // Link to Meta Data of the bookable resource (desc, image links, etc…)
+   }
+    //Submit one or multiple availability - implementation will be off-chain


Why does an offchain functionality appear in the interface of an Ethereum contract?

We did this for pedagogical reasons (easier to understand).
Also, because sample implementation may implement on-chain functions (for testing without scalability)

pirapira · 2018-01-02T14:38:26Z

EIPS/eip-770.md

+   }
+    //Submit one or multiple availability - implementation will be off-chain
+    function publishAvailabilities (address _owner, availability[] _availability, bytes32 signatureProof )  constant returns (uint status);
+    //Query Availabilities - implementation will be off-chain


Why does an offchain functionality appear in the interface of an Ethereum contract?

We did this for pedagogical reasons (easier to understand).
Also, because sample implementation may implement on-chain functions (for testing without scalability)

If an implementation has this function on-chain, is the implementation still compliant to this ERC?

Yes. Because the ERC specified "eventually" off-chain (not mandatory to be off-chain)

pirapira · 2018-01-02T14:38:44Z

EIPS/eip-770.md

+	string                  _metaDataLink // Link to Meta Data of the bookable resource (desc, image links, etc…)
+   }
+    //Submit one or multiple availability - implementation will be off-chain
+    function publishAvailabilities (address _owner, availability[] _availability, bytes32 signatureProof )  constant returns (uint status);


A _ seems to be missing in front of signatureProof.

pirapira · 2018-01-02T14:39:09Z

EIPS/eip-770.md

+    //Request reservation
+    function requestReservation(address _requester, availability _availability)  constant returns (uint status);
+    //Check booking status
+    function getReservationStatus(address _requester, availability _availability)  constant returns (BookingStatus status);


Why is status sometimes BookingStatus and sometimes uint?

Thanks for this relevent remark. The correct type is BookingStatus and this mistake came from a bad copy and paste (from a previous code base)

pirapira · 2018-01-02T14:43:30Z

EIPS/eip-770.md

+
+
+```
+contract ERC770 is ERC20 {


Why does this need to be an ERC20?

Because during the process (step 3.1 or6.1 for instance), the allowance & approve may be called by the RES smart contract

The RES contract doesn't need to be an ERC20 contract for calling allowance or approve. The callee needs to be ERC20, but the caller doesn't need to.

Sorry for my quick reply.
You are right, RES smart contract does not have to be ERC20, however in the sample implementation we are doing it (but not required). Still, the BTU tokens have to ERC20 compliant.
I realize that my description can this code sample is confusion and that it's more clear to separate the token from the RES contract.
This (valuable) feedback will be taken into account in next submission to make things more clear.

pirapira

The use of the Ethereum logo should follow the terms of the license on which it's distributed.

A specification of the on-chain component is desired.

pirapira · 2018-01-02T14:49:31Z

Also, GPL 3.0 is not common in this repository. I'm asking other editors what they think.

Update schema

Adjusting licence

appyhour770 · 2018-01-05T16:35:37Z

Following your comments, i've submitted new files. Waiting for a new (and final) review

appyhour770 · 2018-01-05T16:37:36Z

Following your comments, I've submitted new files for (final) review.

pirapira · 2018-01-24T15:43:38Z

Why does the PNG image say "Ethereum or other platforms"? Is the standard meant for other platforms as well?

Fix typo

appyhour770 · 2018-02-04T21:37:06Z

"Ethereum or other platforms" was referencing, for instance, a private Ethereum network.
For more clarity and since the protocol makes more sense on the public network, this mention has been removed to simply "Ethereum"

pirapira · 2018-02-08T13:51:17Z

@appyhour770 let's just say "Ethereum" because this is an Ethereum Improvement Proposal.

appyhour770 · 2018-02-11T21:35:50Z

"let's just say Ethereum because this is an Ethereum Improvement Proposal"
Agree and PNG updated

Arachnid · 2018-03-27T15:02:00Z

This is a courtesy notice to let you know that the format for EIPs has been modified slightly. If you want your draft merged, you will need to make some small changes to how your EIP is formatted:

Frontmatter is now contained between lines with only a triple dash ('---')
Headers in the frontmatter are now lowercase.

If your PR is editing an existing EIP rather than creating a new one, this has already been done for you, and you need only rebase your PR.

In addition, a continuous build has been setup, which will check your PR against the rules for EIP formatting automatically once you update your PR. This build ensures all required headers are present, as well as performing a number of other checks.

Please rebase your PR against the latest master, and edit your PR to use the above format for frontmatter. For convenience, here's a sample header you can copy and adapt:

---
eip: <num>
title: <title>
author: <author>
type: [Standards Track|Informational|Meta]
category: [Core|Networking|Interface|ERC] (for type: Standards Track only)
status: Draft
created: <date>
---

New EIPs format + Link to reference Implementation

berreb · 2018-05-18T18:15:44Z

@appyhour770 sauf erreur, tu dois écrire:
type: Standards Track
au lieu de
type: Standard

;)

tomsoft1 · 2018-09-10T07:04:20Z

EIPS/eip-808.md

@@ -98,7 +98,7 @@ contract RES {
 	uint                     _minDeposit ; // minimum BTU deposit for booking this resource
 	uint                     _commission ; // commission amount paid to booker in BTU
 	uint                     _freeCancelDateTs; // Limit date for a reservation cancellation
-	uint                     _statDateTs;   //availability start date timestamps
+	uint                     _startDateTs;   //availability start date timestamps
 	uint                     _endDateTs;   //availability end date timestamps
 	BookingStatus    _bookingStatus ; // reservation status
 	string                  _metaDataLink // Link to Meta Data of the bookable resource (desc, image links, etc…)


Should add a semicolumn add the end of _metaDataLink ?

djrosenbaum · 2019-05-10T10:20:19Z

EIPS/eip-770.md

+	uint                     _minDeposit ; // minimum BTU deposit for booking this resource
+	uint                     _commission ; // commission amount paid to booker in BTU
+	uint                     _freeCancelDateTs; // Limit date for a reservation cancellation
+	uint                     _statDateTs;   //availability start date timestamps


typo _startDateTs

axic · 2019-12-16T22:01:39Z

@appyhour770 are you still pursuing this?

appyhour770 · 2019-12-16T22:24:39Z

Yes.

axic · 2019-12-16T22:41:08Z

EIPS/eip-808.md

+
+The BTU protocol involves potentially ten steps and our standardized decentralized reservation contract (RES). Some of following steps can be relayed off-chain, but are always settled on-chain.
+
+<img src="https://raw.githubusercontent.com/appyhour770/image-808/master/protocol-steps.png">


This should be included in the EIP repo. See the images section of EIP-1.

axic · 2019-12-16T22:43:30Z

I think the Specification part could be expanded to be a bit more comprehensive. See EIP-721 and EIP-777 as widely used examples.

axic

Please add discussions-to URL and a Backwards Compatibility section.

github-actions · 2020-09-22T20:09:09Z

There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions · 2020-09-29T20:09:17Z

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

appyhour770 added 5 commits December 26, 2017 21:19

Create eip-770.md

adcffef

Create sample.md

4a35d70

Add files via upload

fdcd1ab

Delete sample.md

4e19775

Finalisating ERC-770 proposal

e5902ad

pirapira added the ERC label Jan 2, 2018

pirapira reviewed Jan 2, 2018

View reviewed changes

pirapira suggested changes Jan 2, 2018

View reviewed changes

appyhour770 added 4 commits January 2, 2018 17:29

Taking into account pirapira comments

8c82970

Taking into account pirapira comments batch ethereum#2

71fde33

Update schema

0948db2

Update schema

Adjusting licence

cd37376

Adjusting licence

hyperfekt mentioned this pull request Jan 23, 2018

ERC: Renting Standard for Rival, Non-Fungible Tokens #809

Closed

appyhour770 added 2 commits February 4, 2018 22:27

Update eip-808.md

ccc5d64

Fix typo

Update

dd1870d

New EIPs format + Link to reference Implementation

8912d4b

New EIPs format + Link to reference Implementation

tomsoft1 reviewed Sep 10, 2018

View reviewed changes

appyhour770 changed the title ~~EIP 770 - ERC for a Standard Decentralized Booking Protocol~~ EIP 808 - ERC for a Standard Decentralized Booking Protocol Nov 5, 2018

Vidal added 4 commits November 5, 2018 16:45

Merge branch 'master' of https://github.com/ethereum/EIPs

8f65a41

Remove image repo + add semicolomn

1406005

Removing eip-808 folder

c19a4d0

Fixing EIP to uptodate template

3dd779d

pelluro mentioned this pull request Dec 18, 2018

ajout BTU contract MetaMask/contract-metadata#211

Merged

djrosenbaum reviewed May 10, 2019

View reviewed changes

axic reviewed Dec 16, 2019

View reviewed changes

axic suggested changes Dec 16, 2019

View reviewed changes

github-actions bot added the stale label Sep 22, 2020

github-actions bot closed this Sep 29, 2020


		## Abstract

		The following describes standard functions for a decentralized booking protocol that can be used to reserve any kind of resource (Hotel, concert ticket, restaurant table).


		(Step 6.2 - Optional) Provider cancels the reservation by broadcasting a cancellation request. This triggers a submission to the RES smart contract that empties the registries for this resource. RES smart contract is releasing the escrowed amount to booker.

		(Step 7.1 & 7.2) Booker is notifying that the resource has been paid (presumably at resource check-out). RES smart contract is releasing the escrowed BTU back to user in addition to a BTU agreed commision.


		## Motivation

		The Booking Token Unit (BTU) protocol is a building block for any decentralized application (dApp) or web site willing to implement booking features for their end-users.


		The BTU protocol involves potentially ten steps and our standardized decentralized reservation contract (RES). Some of following steps can be relayed off-chain, but are always settled on-chain.

		<img src="./eip-770/protocol-steps.png">


		<img src="./eip-770/protocol-steps.png">

		Hereafter the general sequence :


		(Step 7.1 & 7.2) Booker is notifying that the resource has been paid (presumably at resource check-out). RES smart contract is releasing the escrowed BTU back to user in addition to a BTU agreed commision.

		## Implementation


		The BTU protocol involves potentially ten steps and our standardized decentralized reservation contract (RES). Some of following steps can be relayed off-chain, but are always settled on-chain.

		<img src="https://raw.githubusercontent.com/appyhour770/image-808/master/protocol-steps.png">

EIP 808 - ERC for a Standard Decentralized Booking Protocol #808

EIP 808 - ERC for a Standard Decentralized Booking Protocol #808

Conversation

appyhour770 commented Dec 26, 2017 • edited Loading

pirapira commented Jan 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pirapira Jan 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pirapira left a comment

Choose a reason for hiding this comment

pirapira commented Jan 2, 2018

appyhour770 commented Jan 5, 2018

appyhour770 commented Jan 5, 2018

pirapira commented Jan 24, 2018

appyhour770 commented Feb 4, 2018

pirapira commented Feb 8, 2018

appyhour770 commented Feb 11, 2018

Arachnid commented Mar 27, 2018

berreb commented May 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

axic commented Dec 16, 2019

appyhour770 commented Dec 16, 2019 • edited Loading

Choose a reason for hiding this comment

axic commented Dec 16, 2019

axic left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 22, 2020

github-actions bot commented Sep 29, 2020

appyhour770 commented Dec 26, 2017 •

edited

Loading

pirapira Jan 2, 2018 •

edited

Loading

appyhour770 commented Dec 16, 2019 •

edited

Loading