Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-2537: update precompile addresses to avoid collision with latest precompile set #7214

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Update EIP-2537: update precompile addresses to avoid collision with latest precompile set #7214

merged 4 commits into from
Jun 22, 2023

Conversation

ralexstokes
Copy link
Member

puts 2537 precompiles after the latest mainnet precompiles in #4788

@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Jun 22, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 22, 2023 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title update precompile addresses to avoid collision with latest precompile set Update EIP-2537: update precompile addresses to avoid collision with latest precompile set Jun 22, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Jun 22, 2023
@github-actions
Copy link

The commit 655572c (as a parent of a17d5a3) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 22, 2023
@jochem-brouwer jochem-brouwer mentioned this pull request Jun 22, 2023
Merged
g11tech
g11tech approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech
Copy link
Contributor

g11tech commented Jun 22, 2023

linter failure

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 22, 2023
jochem-brouwer
jochem-brouwer approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xinbenlv
xinbenlv approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Per #7198, we should let contributor submit without fixing the linter error of untouched lines except for moving status.

@ralexstokes it seems the EIPW errors now are all warnings. If you still have difficulty triggering eth-bot's action, try change click on this "Convert to draft" (sorry if the "draft" here seems confusing with the EIP status Draft. They are two things.)

image

Then click on "Ready for Review" which might help re-trigger the eth-bot. (sorry if the "review" here seems confusing with the EIP status Review. They are two things.)

image

@ralexstokes
Copy link
Member Author

at this point we just need @ineffectualproperty or @shamatar to approve, I've also added myself as an author so I can update this EIP moving forward w/o needing to involve them

@eth-bot eth-bot enabled auto-merge (squash) June 22, 2023 22:51
eth-bot
eth-bot approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ef0a132 into ethereum:master Jun 22, 2023
@flcl42 flcl42 mentioned this pull request Jun 23, 2023
Merged
12 tasks
@ralexstokes ralexstokes deleted the refresh-2537 branch June 23, 2023 16:38
@yperbasis yperbasis mentioned this pull request Jul 28, 2023
Merged
yperbasis added a commit to erigontech/erigon that referenced this pull request Jul 28, 2023
@yperbasis
Update EIP-2537 and EIP-4844 precompile addresses (#7940)
27125b3 
See ethereum/EIPs#7172 &
ethereum/EIPs#7214
AskAlexSharov pushed a commit to erigontech/erigon that referenced this pull request Sep 6, 2023
@yperbasis @AskAlexSharov
Update EIP-2537 and EIP-4844 precompile addresses (#7940)
c599c01 
See ethereum/EIPs#7172 &
ethereum/EIPs#7214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

@g11tech g11tech g11tech approved these changes

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

@shamatar shamatar shamatar approved these changes

@xinbenlv xinbenlv xinbenlv approved these changes

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ralexstokes @eth-bot @g11tech @xinbenlv @shamatar @jochem-brouwer