You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should remove all newly added functions (including getters) on L1 contracts. However we should minimize changes to the initialize() functions (meaning it is fine to keep the systemConfig address as a new input to the bridge contracts, and as a state var, but it should become internal).
Description
Build on the work begun in #13589 to completely remove cgt code from L1 code paths. No further work should be done to L2 code paths.
The full set of ABI changes from CGT can be seen here: https://github.com/ethereum-optimism/optimism/pull/10143/files#diff-97745aae7f1af56cec3629873b886e53b94123dedbae6b3db26babb1ed50354b
We should remove all newly added functions (including getters) on L1 contracts. However we should minimize changes to the
initialize()
functions (meaning it is fine to keep thesystemConfig
address as a new input to the bridge contracts, and as a state var, but it should become internal).Specifically:
systemConfig
variable internal_systemConfig
argumentsystemConfig
variable internal_systemConfig
argumentgasPayingToken()
isCustomGasToken()
gasPayingTokenName()
gasPayingTokenSymbol()
_setGasPayingToken()
gasPayingToken
fromAddresses
structbalance()
depositERC20Transaction()
setGasPayingToken()
Note that the SystemConfig should be the only contract with changes to the initializer.
In the above contracts, unused branching code, errors and events should also be removed.
Where state vars are removed a spacer should be added.
The text was updated successfully, but these errors were encountered: