Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all necessary contracts to the SystemConfig’s Addresses struct #13073

Open
Tracked by #13069
maurelian opened this issue Nov 25, 2024 · 0 comments
Open
Tracked by #13069

Add all necessary contracts to the SystemConfig’s Addresses struct #13073

maurelian opened this issue Nov 25, 2024 · 0 comments

Comments

@maurelian
Copy link
Contributor

maurelian commented Nov 25, 2024

The OPCM uniquely identifies each OP Chain by its SystemConfig. For upgrades the OPCM will retrieve the Addresses struct from the SystemConfig to identify all contracts it needs to interact with during the upgrade process.

Currently that struct is lacking certain contracts which are required, including:

  • AddressManager
  • DelayedWeth(s)
    • although these might be best retrieved by querying: gameImpl(DisputeGameFactory.gameImpls(n)).weth()

A new getter should also be added to the SystemConfig to retrieve the full Addresses struct in a single call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant