Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM Engineering: propose moving dispute/cannon contracts to appropriate folders #12643

Open
1 of 3 tasks
Tracked by #12703
smartcontracts opened this issue Oct 25, 2024 · 1 comment
Open
1 of 3 tasks
Tracked by #12703
Assignees

Comments

@smartcontracts
Copy link
Contributor

smartcontracts commented Oct 25, 2024

Contracts within the dispute and cannon folders are L1 contracts but live in distinct folders for no clear reason. I propose that we should consider one of two things:

  1. We move these contracts into the L1 folder just like any other contract
  2. We add some new subfolders to the L1 folder to organize things like L1/cannon, L1/dispute, L1/bridge, L1/core etc etc

Tasks here:

  • Open a design doc with both of these options presented (also third option, don't move the contracts)
  • Figure out what to do
  • If we make a decision, execute on it
@K-Ho
Copy link
Contributor

K-Ho commented Nov 25, 2024

Flagging context from Kelvin that "this technically does change the contract source code because the import paths will change, so it does need to be included in an upgrade"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

4 participants
@K-Ho @smartcontracts @AmadiMichael and others