Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable macOS builds for AMD64 #330

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Conversation

odkr
Copy link
Contributor

@odkr odkr commented Nov 25, 2024

No description provided.

.github/workflows/manual.yml Outdated Show resolved Hide resolved
@tasn
Copy link
Member

tasn commented Nov 26, 2024

Is this ready to be merged? I made one change (to remove your test code to drive it as a workflow).

@tasn
Copy link
Member

tasn commented Nov 26, 2024

(the lint was fixed in master btw)

@odkr
Copy link
Contributor Author

odkr commented Nov 26, 2024

Is this ready to be merged? I made one change (to remove your test code to drive it as a workflow).

Yes. The only other change is the macOS runner, which is now macOS 13. I'll open issues for the Apple Silicon build in the etebase repo. Or would you rather I did that elsewhere?

@tasn
Copy link
Member

tasn commented Nov 26, 2024

Are there Apple Sillicon runners? If so, please just add it as another matrix item (in a new PR)!

@tasn tasn merged commit 7f38187 into etesync:master Nov 26, 2024
12 of 13 checks passed
@odkr
Copy link
Contributor Author

odkr commented Nov 26, 2024

Are there Apple Sillicon runners? If so, please just add it as another matrix item (in a new PR)!

macOS 14 appears to be an Apple Silicon runner (emphasis on "appears", I think I saw filenames that contain "aarch64" in the output).

However, etebase doesn't build on that runner (for the reasons I gave in #328). I can get it to build with the etebase version from the etebase repository, but (a) those would be very different build instructions and (b) I’m not sure that build even works; I can't get either Thunderbird or or macOS to connect to etesync-dav when I use it. Shall we move that discussion to a ticket in etebase? Or a separate ticket here?

@tasn
Copy link
Member

tasn commented Nov 26, 2024

Ah I forgot about that ticket.

Yeah, let's do a ticket for building etebase-py on arm at the appropriate repo. Thanks!

@tasn
Copy link
Member

tasn commented Nov 26, 2024

P.S, build succeeded for macOS, thanks!

@odkr
Copy link
Contributor Author

odkr commented Nov 26, 2024

Yeah, let's do a ticket for building etebase-py on arm at the appropriate repo. Thanks!

Here you go: etesync/etebase-py#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants