Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support radicale 3.2.2 #318

Merged

Conversation

ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Aug 31, 2024

Fixes runtime error using radicale 3.2.2:

Traceback (most recent call last):
  File "/nix/store/wd2by7xjf0cx15nwdxg395x0zsfja50g-etesync-dav-0.32.1/bin/.etesync-dav-wrapped", line 164, in <module>
    radicale_main.run(radicale_args + sys.argv[1:])
  File "/nix/store/wd2by7xjf0cx15nwdxg395x0zsfja50g-etesync-dav-0.32.1/lib/python3.12/site-packages/etesync_dav/radicale_main/__init__.py", line 136, in run
    log.set_level(configuration.get("logging", "level"))
TypeError: set_level() missing 1 required positional argument: 'backtrace_on_debug'

Probably not worth merging as is, because it breaks runtime with radicale versions before 3.2.2 in the opposite way:

Traceback (most recent call last):
  File "/nix/store/l6s0cp2x0gbbrbxykfjb0v78gzq3q12w-etesync-dav-0.32.1/bin/.etesync-dav-wrapped", line 164, in <module>
    radicale_main.run(radicale_args + sys.argv[1:])
  File "/nix/store/l6s0cp2x0gbbrbxykfjb0v78gzq3q12w-etesync-dav-0.32.1/lib/python3.12/site-packages/etesync_dav/radicale_main/__init__.py", line 136, in run
    log.set_level(configuration.get("logging", "level"), configuration.get("logging", "backtrace_on_debug"))
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/diygrl5c0fqqp5mgrhmcckqrwka54krd-radicale-3.2.1/lib/python3.12/site-packages/radicale/config.py", line 418, in get
    raise KeyError(section, option)
KeyError: ('logging', 'backtrace_on_debug')

There could be some way to check and do conditional instead.

- add changes to log.set_level() from upstream radicale update
(additional second arg - backtrace_on_debug):
https://www.github.com/Kozea/Radicale/pull/1519
@ghpzin ghpzin marked this pull request as ready for review August 31, 2024 16:19
@tasn
Copy link
Member

tasn commented Sep 2, 2024

Thanks!

@tasn tasn merged commit 3822beb into etesync:master Sep 2, 2024
8 of 16 checks passed
@ghpzin ghpzin deleted the etesync-dav/fix-runtime-with-radicale-3.2.2 branch September 3, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants