Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create an --eth-protocol=[65|64|63] flag? #109

Closed
meowsbits opened this issue Jun 1, 2020 · 2 comments · Fixed by #244
Closed

create an --eth-protocol=[65|64|63] flag? #109

meowsbits opened this issue Jun 1, 2020 · 2 comments · Fixed by #244
Labels
F7-optimisation 💊 M2-config 📂 P7-nicetohave 🐕 Q2-easy 💃

Comments

@meowsbits
Copy link
Member

meowsbits commented Jun 1, 2020 •
edited
Loading

Just an idea to allow the Ethereum Protocol version to be user configurable, which would provide a simple fix for issues like the ones Besu and Parity OpenEthereum are having on ETC right now. https://github.com/openethereum/openethereum/issues/11744

https://github.com/etclabscore/core-geth/blob/master/eth/protocol.go#L43
@meowsbits
Copy link
Member Author

les.protocol version would be a welcome addition, too, though I would think a second step after the eth-protocol feature.

@ziogaschr ziogaschr mentioned this issue Nov 26, 2020
Merged
@ziogaschr
Copy link
Member

les.protocol version would be a welcome addition, too, though I would think a second step after the eth-protocol feature.

@meowsbits eth.protocols has been handled in #244.
Do you want to handle the les.protocol in same PR or in a new one? Actually, I am not sure if it makes sense to handle les.protocol at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F7-optimisation 💊 M2-config 📂 P7-nicetohave 🐕 Q2-easy 💃
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Ethereum protocol version to be set user configurable etclabscore/core-geth
2 participants
@ziogaschr @meowsbits